[PATCH wayland] add apis to enable/disable wayland debug at runtime

[Marek Chalupa]

Hi,

I like this idea, it can be handy when debugging just a part of code (I 
wrote similar patch once actually, but then I forgot about it and never 
sent it to the list). However, the implementation could be better IMHO:

I don't think we should move the variables to wayland-util.c. You don't 
need debug_server in wl_debug_client_enable() and vice versa, so you can 
keep the original variables in place. Also the functions declarations 
shouldn't be in wayland-private.h, since this file is not installed and 
you WL_EXPORT them. If it is a public API it should be in 
wayland-client/server-core.h (and implementation in client/server.c files)

And the patch does not apply due to some binary blob

Regards,
Marek

On 11/13/2015 11:33 AM, 박성진 wrote:
> Hello,
> I added two apis in wayland-util to enable/disable display of wayland debug
> information at runtime.
>
> I had a difficulty to see wayland debug information at runtime when I'd
> like to debug both a compositor and client(s).
> And I found that there is no proper apis yet to enable/disable wayland
> debug information at runtime.
>
> Actually, we already know that we can see wayland debug information by
> setting WAYLAND_DEBUG environment to 1.
> But the environment will merely check when a compositor creates a wayland
> display or a client tries to connect to an wayland display.
> IMO, it's better to have the additional apis to enable/disable wayland
> debug information at runtime.
> It would also help if we are to catch the problems associated with timing.
>
> Plz kindly review this patch.
>
> Thanks,
> Sung-Jin Park
>
>
>
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/wayland-devel
>