[PATCH weston] compositor-fbdev: Drop intermediate shadow buffer

[Derek Foreman]

On 07/12/15 03:55 AM, Pekka Paalanen wrote:
> On Fri,  4 Dec 2015 19:20:12 -0600
> Derek Foreman <derekf at osg.samsung.com> wrote:
> 
>> From: Sjoerd Simons <sjoerd.simons at collabora.co.uk>
>>
>> Currently the fbdev compositor has its own shadow buffer when rendering
>> with pixman, causing the following copies to occur:
>>
>> [pixman shadow buffer] -> [fbdev shadow buffer] -> [fbdev hardware]
>>
>> As the pixman render already does all output translation when
>> compositing the intermediate shadow buffer really isn't needed, so drop
>> it.
>>
>> As a side-effect this fixes updating the fbdev hardware for outputs not
>> starting at 0x0.
>>
>> Signed-off-by: Sjoerd Simons <sjoerd.simons at collabora.co.uk>
>> ---
>>
>> Pekka and I were talking about this earlier and remembered seeing this patch.
>>
>> I thought it had already landed, but apparently not.
>>
>> All I've done is rebase it, will try to get around to reviewing it next week
>> as the pixman renderer is still uselessly allocating an extra shadow buffer.
> 
> You mean the fbdev-backend? ;-)
> 
> Will be good to remove a useless copy in the fbdev case indeed.
> 
> 
>>  src/compositor-fbdev.c | 68 +++-----------------------------------------------
>>  1 file changed, 3 insertions(+), 65 deletions(-)
> 
> Reviewed-by: Pekka Paalanen <pekka.paalanen at collabora.co.uk>
> 
> But I didn't test it.

Well, I've now tested it.

Reviewed-by: Derek Foreman <derekf at osg.samsung.com>
Tested-by: Derek Foreman <derekf at osg.samsung.com>

I figure that's enough review and testing, so I'm pushing it now.

> Thanks,
> pq
> 
> 
> 
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/wayland-devel
>