[PATCH weston 1/2] configure.ac: Don't look for Xwayland in the weston install destination

Derek Foreman derekf at osg.samsung.com
Tue Feb 10 08:03:04 PST 2015


On 10/02/15 09:22 AM, sardemff7+wayland at sardemff7.net wrote:
> On 2015-02-10 03:15, Bryce Harrington wrote:
>> Turns out the issue I've run into is that the --with-xserver-path
>> setting doesn't get passed down into distcheck, which calls configure
>> like this:
>>
>>            && $(am__cd) $(distdir)/_build \
>>            && ../configure \
>>              $(AM_DISTCHECK_CONFIGURE_FLAGS) \
>>              $(DISTCHECK_CONFIGURE_FLAGS) \
>>              --srcdir=.. --prefix="$$dc_install_base" \
>>            && $(MAKE) $(AM_MAKEFLAGS) \
>>
>> Setting --with-xserver-path in AM_DISTCHECK_CONFIGURE_FLAGS doesn't seem
>> to work (it ends up confusing config.sub mightily), but setting it in
>> DISTCHECK_CONFIGURE_FLAGS seems to produce valid results.
> 
> DISTCHECK_CONFIGURE_FLAGS is for user-defined distcheck flags, you must
> not define in your Makefile.am. I would rather find what is going on
> with AM_DISTCHECK_CONFIGURE_FLAGS, any log to share?
> 

Actually, I think DISTCHECK_CONFIGURE_FLAGS is exactly what Bryce wants
to use for this.

Bryce has Xwayland installed in a non-standard location so as to not
interfere with his system binaries, so we don't want anything in
Makefile.am to be specific to his installation anyway.

DISTCHECK_CONFIGURE_FLAGS=--with-xserver-path=/wherever/it/is/Xwayland
make distcheck

should make the test pass just fine, and I think it's reasonable to
expect that without any good way to detect Xwayland's location.

FWIW, I still think the patch that started this thread is worthwhile,
though.  :)



More information about the wayland-devel mailing list