[PATCH weston] configure.ac: make use of wayland-scanner.pc

[Emil Velikov]

On 23 February 2015 at 15:31, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> On 23 February 2015 at 14:10,  <sardemff7+wayland at sardemff7.net> wrote:
>> On 2015-02-17 16:13, Emil Velikov wrote:
>>>
>>> Currently we use the wayland-scanner executable as found with
>>> AC_PATH_PROG, and then check the presence of wayland-scanner.pc
>>>
>>> Currently the latter is unused even if AC_PATH_PROG fails to find the
>>> binary. Rework things to use the pkg-config variable as a fall-back.
>>>
>>> Cc: Andrew Oakley <aoakley at espial.com>
>>> Cc: Bill Spitzak <spitzak at gmail.com>
>>> Cc: Daniel Stone <daniel at fooishbar.org>
>>> Signed-off-by: Emil Velikov <emil.l.velikov at gmail.com>
>>> ---
>>>   configure.ac | 5 ++---
>>>   1 file changed, 2 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/configure.ac b/configure.ac
>>> index 1db9f79..b44675f 100644
>>> --- a/configure.ac
>>> +++ b/configure.ac
>>> @@ -503,11 +503,10 @@ AM_CONDITIONAL(HAVE_LCMS, [test "x$have_lcms" =
>>> xyes])
>>>
>>>   AC_PATH_PROG([wayland_scanner], [wayland-scanner])
>>
>>
>> We should (must) set wayland_scanner as precious with AC_ARG_VAR. Probably a
>> good idea to put that in this patch directly. (Ouch, I just saw that I did
>> not add it in a patch of mine, shame on me.)
>>
>> Also, AC_PATH_TOOL (or AC_PATH_TARGET_TOOL) may be a better choice
>> considering the usage of wayland-scanner. Would the scanner generate
>> *anything* different depending on the host(/target) platform? If so, it’s a
>> (target) tool and AC_PATH_TOOL is the best way to go.
>>
>> By the way, it seems sensible to me to ask for it in the standard PATH in
>> all cases, as the C compiler is required, thus making the pkg-config check
>> useless. I would consider wayland-scanner as part of the cross-compiling
>> toolchain, not a library. You do have to *run* it on the compiling machine,
>> right?
>>
> Well my idea is that wayland-scanner is build for and used on the
> --build platform, as such the package should not exist within the host
> specific PKG_CONFIG_PATH. That aside v2 shifts things and uses the
> variable in wayland-scanner.pc as a fall-back, based on popular demand
> :-)
>
*cough* silly me - got confused that this is v1 due to missing history :-\

-Emil