[PATCH weston 03/10] xdg-shell: Take a xdg_surface as the parent surface
jadahl at gmail.com
Mon Feb 23 07:53:57 PST 2015
On Mon, Feb 23, 2015 at 04:01:09PM +0200, Pekka Paalanen wrote:
> On Fri, 13 Feb 2015 14:01:55 +0800
> Jonas Ådahl <jadahl at gmail.com> wrote:
> > From: "Jasper St. Pierre" <jstpierre at mecheye.net>
> > There is no other valid surface that we should be using here.
> > ---
> > clients/window.c | 14 +++++++-------
> > desktop-shell/shell.c | 12 ++++++------
> > protocol/xdg-shell.xml | 2 +-
> > 3 files changed, 14 insertions(+), 14 deletions(-)
> > diff --git a/protocol/xdg-shell.xml b/protocol/xdg-shell.xml
> > index 776438b..6abfabd 100644
> > --- a/protocol/xdg-shell.xml
> > +++ b/protocol/xdg-shell.xml
> > @@ -152,7 +152,7 @@
> > unmapped if the parent is unmapped too. They should not appear
> > on task bars and alt+tab.
> > </description>
> > - <arg name="parent" type="object" interface="wl_surface" allow-null="true"/>
> > + <arg name="parent" type="object" interface="xdg_surface" allow-null="true"/>
> > </request>
> > <request name="set_title">
> Reviewed-by: Pekka Paalanen <pekka.paalanen at collabora.co.uk>
> Do we want to collect all xdg-shell.xml changes to be applied in the
> same push, or is it ok to push patch by patch when they get reviewed?
I think all xdg-shell protocol related patches should be pushed all at
once. Assuming we don't make any changes to the proposed v5, I don't
think we need to bump the version an extra time as well, for this
series. If changes are required, we need to bump it to v6, as v5 is
already pushed to GNOME.
> If we do patch by patch, then Weston master's xdg-shell will broken
> without a version bump, which will be very annoying for anyone running
> master branch with other apps using xdg-shell.
More information about the wayland-devel