[PATCH libinput 12/26] tablet: explicitly ignore ABS_THROTTLE, ABS_RX, ABS_RY, and ABS_RZ

Peter Hutterer peter.hutterer at who-t.net
Wed Feb 25 17:38:04 PST 2015


On Wed, Feb 25, 2015 at 05:29:49PM -0800, Jason Gerecke wrote:
> 
> On 2/23/2015 10:21 PM, Peter Hutterer wrote:
> >ABS_THROTTLE:
> >	Tablets still advertise this axis but the mouse itself isn't available
> >	anymore. The Pad sends the second wheel as ABS_THROTTLE but that's a
> >	task for the buttonset interface.  Explanation of what the throttle
> >	did on page
> >	http://101.wacom.com/productsupport/manual/Intuos2UsersManual.pdf
> >
> >ABS_RX/ABS_RY:
> >	These only happen on the Intuos3 device and only on the Pad device
> >	(kernel >= 3.17)
> >
> >ABS_RZ:
> >	The 4D mouse for the Intuos2, obsolete.
> >
> >No functional changes, this is to clarify why we're only handling a subset of
> >codes.
> >
> >Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
> >---
> >  src/evdev-tablet.c | 11 +++++++++++
> >  1 file changed, 11 insertions(+)
> >
> >diff --git a/src/evdev-tablet.c b/src/evdev-tablet.c
> >index 14fb44f..820473f 100644
> >--- a/src/evdev-tablet.c
> >+++ b/src/evdev-tablet.c
> >@@ -71,6 +71,17 @@ tablet_process_absolute(struct tablet_dispatch *tablet,
> >  	case ABS_MISC:
> >  		tablet->current_tool_id = e->value;
> >  		break;
> >+	/* Intuos 3 strip data. Should only happen on the Pad device, not on
> >+	   the Pen device. */
> >+	case ABS_RX:
> >+	case ABS_RY:
> >+	/* Only on the 4D mouse (Intuos2), obsolete */
> >+	case ABS_RZ:
> >+	/* Only on the 4D mouse (Intuos2), obsolete.
> >+	   The 24HD sends ABS_THROTTLE on the Pad device for the second
> >+	   wheel but we shouldn't get here on kernel >= 3.17.
> >+	   */
> >+	case ABS_THROTTLE:
> >  	default:
> >  		log_info(device->base.seat->libinput,
> >  			 "Unhandled ABS event code %#x\n", e->code);
> Just to confirm: these axes aren't ignored because they're problematic, but
> because supporting those old tools isn't worth the effort? I don't think I
> can complain :)

yep, Intuos3 is the oldest I can see us reasonably supporting.

Cheers,
   Peter
 


More information about the wayland-devel mailing list