[PATCH weston v2] xdg-shell: Send an error when the client uses the not-topmost popup

[Pekka Paalanen]

On Thu, 26 Feb 2015 17:02:21 +0800
Jonas Ådahl <jadahl at gmail.com> wrote:

> From: "Jasper St. Pierre" <jstpierre at mecheye.net>
> 
> Either in destroy or get_xdg_popup.
> 
> [jadahl: Verify that the new popup is the top most when mapping instead
> of creating. Some renaming.]
> ---
> 
> Changes since v1:
> 
> Renamed get_top_xdg_popup to get_top_popup
> 
> Removed the assert in get_top_popup
> 
> Only verify top most requirement for xdg popups
> 
>  desktop-shell/shell.c  | 58 +++++++++++++++++++++++++++++++++++++++++++++-----
>  protocol/xdg-shell.xml |  7 ++++++
>  2 files changed, 60 insertions(+), 5 deletions(-)

...

> diff --git a/protocol/xdg-shell.xml b/protocol/xdg-shell.xml
> index 4414d46..360179d 100644
> --- a/protocol/xdg-shell.xml
> +++ b/protocol/xdg-shell.xml
> @@ -398,6 +398,13 @@
>        xdg_popup surfaces are always transient for another surface.
>      </description>
>  
> +    <enum name="error">
> +      <description summary="xdg_popup error values">
> +	These errors can be emitted in response to xdg_popup requests.
> +      </description>
> +      <entry name="not_the_topmost_popup" value="0" summary="The client tried to destroy a non-toplevel popup"/>

s/toplevel/topmost/ still ;-)

> +    </enum>
> +
>      <request name="destroy" type="destructor">
>        <description summary="remove xdg_surface interface">
>  	The xdg_surface interface is removed from the wl_surface object

With the typo fixed,
Reviewed-by: Pekka Paalanen <pekka.paalanen at collabora.co.uk>

Thanks,
pq