[PATCH] Enhance wayland-scanner so it can use files for input and output.

Daniel Stone daniel at fooishbar.org
Fri Feb 27 03:05:25 PST 2015


Hi,
A bunch of nitpicks follow, I'm afraid.

On 26 February 2015 at 09:48, Jussi Pakkanen <jpakkane at gmail.com> wrote:
>     * Enhance wayland-scanner so it can use files for input and output
>       to improve flexibility and testability.
>
>     Signed-off-by: Jussi Pakkanen <jpakkane at gmail.com>

For future, please drop the leading asterisk and spaces. Also, that
the commit enhances something is a given - why would you apply
something which doesn't improve anything? 'Add support for direct file
writing in wayland-scanner' might be a better choice.

 > @@ -1273,6 +1277,26 @@ int main(int argc, char *argv[])
>         else
>                 usage(EXIT_FAILURE);
>
> +       if(argc == 4) {

Space before opening parentheses for all block/conditionals
(if/while/for/etc) please: 'if (argc == 4) {'.

Otherwise looks good to me, and these could just as easily be fixed up
whilst applying:
Reviewed-by: Daniel Stone <daniels at collabora.com>

Cheers,
Daniel


More information about the wayland-devel mailing list