[PATCH] libinput-seat: Don't regard no input devices as failure

Daniel Stone daniel at fooishbar.org
Fri Jan 2 05:07:57 PST 2015


Hi,

On 2 January 2015 at 12:24, Sjoerd Simons <sjoerd.simons at collabora.co.uk>
wrote:

> Under the assumption that weston-launch is a tool for developers to
> start weston, then sure fine. If weston-launch gets used to autostart
> weston on bootup (as i'm doing in some cases), that behaviour is
> horrible.
>

It's not a developer tool. If you're launching weston directly, either
you've done something 'clever' with DRM/input device permissions, or you're
running as root. I'm not 100% sure if running weston directly even works.

Apart from blatent configuration issues there can be a lot of reasons
> why there are no input devices available at the time weston start,
> which can range from devices not being plugged in to devices not being
> enumerated yet (which can potentially happen with USB input devices,
> but are a lot more likely with bluetooth devices).. In those cases
> it's a lot more user-friendly to display an onscreen message indicating
> there are no input devices instead of simply aborting.
>

But what do you do after that? Do you display the message and abort
(leaving either console -> background -> error message in a tight loop if
auto-restart is enabled), in which case there's no real difference to the
current behaviour? Or do you display a message and leave the user no way to
kill weston other than SSH, in which case there's no difference to the
behaviour with this patch?

Cheers,
Daniel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/wayland-devel/attachments/20150102/e9313fae/attachment.html>


More information about the wayland-devel mailing list