[PATCH weston 3/6] compositor: set presentation.presented flags

Bryce Harrington bryce at osg.samsung.com
Tue Jan 20 17:23:57 PST 2015


On Tue, Jan 20, 2015 at 10:11:56AM +0200, Pekka Paalanen wrote:
> On Fri, 16 Jan 2015 08:48:21 +0100
> Mario Kleiner <mario.kleiner.de at gmail.com> wrote:
> 
> > Hi Pekka,
> > 
> > as you know from our off-list conversation i've spent quite a bit of 
> > time the
> > last week reviewing and testing this patch series (patches 1-6). I 
> > implemented
> > a first basic usable Waylang backend into my own software and tested 
> > this patch
> > series with it wrt. timestamp reliability etc. and it so far looks good 
> > to me, at least
> > for a first iteration of the presentation_feedback extension.
> > 
> > Tested on x11 backend, wayland backend, and mostly on the native drm 
> > backend.
> > On the drm backend i tested single- and dual-dispaly, on Intel-kms and 
> > nouveau-kms,
> > windowed and fullscreen, with/without overlay planes on, opaque or 
> > transparent, etc.
> > 
> > My hardware measurement equipment confirms that timestamps are precise
> > and reliable wrt. reality as long as the overlay planes are not used, ie.
> > everything goes through regular kms-pageflip. Precision on the drm backend
> > is better than 40 microseconds wrt. to the external measurement hardware,
> > as expected, essentially perfect :)
> > 
> > So fwiw the whole series is
> > 
> > Reviewed-by: Mario Kleiner <mario.kleiner.de at gmail.com>
> > Tested-by: Mario Kleiner <mario.kleiner.de at gmail.com>
> > 
> > and enthusiastically
> > 
> > Acked-by: Mario Kleiner <mario.kleiner.de at gmail.com>
> > 
> > for inclusion into Wayland/Weston 1.7, which is why i'm cc'ing Bryce for 
> > hopefully getting this in.
> 
> Thank you Mario! You have done some hard work. :-)
> 
> Could someone push this series with Mario's tags added, please?
> The major feature of Presentation feedback is already in, so I
> think this is still ok wrt. to the release cycle.

I've pushed this series with the tags added, except for patch 6 which is
labeled "not for upstream".

To ssh://git.freedesktop.org/git/wayland/weston
   7eca8cc..b77acf5  master -> master

Bryce


More information about the wayland-devel mailing list