[PATCH weston] compositor-x11: Move the x11 event handler to the display loop

[Daniel Stone]

Hi,

On 19 December 2014 at 15:02, Pekka Paalanen <ppaalanen at gmail.com> wrote:
> On Fri, 19 Dec 2014 08:08:33 -0600
> Derek Foreman <derekf at osg.samsung.com> wrote:
>> On 19/12/14 06:40 AM, Pekka Paalanen wrote:
>> > There is some fancy input scheduling going on with the repaint loop, so
>> > that input events would be sent as a burst to the clients when the
>> > compositor is spinning in the repaint loop. The idea is that because
>> > clients repaint only once per cycle, they don't need to be woken up due
>> > to input any more often than that. Or that's how I understood it.
>> >
>> > The problem here, I assume, is that the X11 fd is not only input, but
>> > also output events, unlike DRM backend where the DRM fd is separate.
>> >
>> > I would be inclined to just take this patch, because it fixes a bug and
>> > the x11 backend is of lesser quality anyway.
>>
>> Hmmm, I think the only event that matters is XCB_CLIENT_MESSAGE (delete
>> window).  Can't I just handle that from an idle callback?
>
> I suppose, but is it worth it? :-)

Yeah, I think it'd be worth doing so. Especially if we want to run
tests on the X11 backend, or rely on it not crashing ...

The idle-handler thing sounds good to me.

Cheers,
Daniel