[PATCH wayland 2/8] test-compositor: extend leak checks into clients

Marek Chalupa mchqwerty at gmail.com
Wed Jan 28 08:38:46 PST 2015


On Tue, Jan 27, 2015 at 1:24 PM, Daniel Stone <daniel at fooishbar.org> wrote:

> Hi,
>
> On 19 December 2014 at 13:53, Marek Chalupa <mchqwerty at gmail.com> wrote:
> > diff --git a/tests/test-compositor.h b/tests/test-compositor.h
> > index c41b17b..f77a5db 100644
> > --- a/tests/test-compositor.h
> > +++ b/tests/test-compositor.h
> > @@ -95,3 +95,9 @@ struct client_info *client_create_with_name(struct
> display *d,
> >                                             void (*client_main)(void),
> >                                             const char *name);
> >  #define client_create(d, c) client_create_with_name((d), (c), (#c))
> > +
> > +#define TEST_CLIENT_NOT_USING_WL_DISPLAY_CONNECT               \
> > +       do {                                                    \
> > +               extern int not_using_wl_display_connect;        \
> > +               not_using_wl_display_connect = 1;               \
> > +       } while(0);
>
> I really like this series, but this bit seems a bit fragile. How about
> something like the two attached patches, which seems to work for me?
> The first one can be squashed into this patch, and the second into the
> follow-up.
>

Yeah, your solution is much better than mine, I like it. The Bill's
addition looks quite good too. . Feel free to squeeze it/follow-up. Or do
you want me to re-post version 2?

Thanks,
Marek


> Cheers,
> Daniel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/wayland-devel/attachments/20150128/ecf1932c/attachment.html>


More information about the wayland-devel mailing list