[PATCH weston] logind-util: Use %u for unsigned int in snprintf

Marek Chalupa mchqwerty at gmail.com
Wed Jul 1 03:29:00 PDT 2015


sizeof operator returns size_t, which need not to be unsigned int, but can
be long (long) unsigned int.
So here the correct fix should be either to use %zu (since C99) or cast it
to unsigned long and use %lu

Regards,
Marek

On Sat, Jun 20, 2015 at 1:28 AM, Bryce Harrington <bryce at osg.samsung.com>
wrote:

> Addresses this warning found by Denis Denisov:
>
>   [src/logind-util.c:702]: (warning) %d in format string (no. 1)
>   requires 'int' but the argument type is 'unsigned int'.
>
> Signed-off-by: Bryce Harrington <bryce at osg.samsung.com>
> ---
>  src/logind-util.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/logind-util.c b/src/logind-util.c
> index 5c95874..006a1ae 100644
> --- a/src/logind-util.c
> +++ b/src/logind-util.c
> @@ -702,7 +702,7 @@ weston_logind_setup_vt(struct weston_logind *wl)
>         sigset_t mask;
>         struct wl_event_loop *loop;
>
> -       snprintf(buf, sizeof(buf), "/dev/tty%d", wl->vtnr);
> +       snprintf(buf, sizeof(buf), "/dev/tty%u", wl->vtnr);
>         buf[sizeof(buf) - 1] = 0;
>
>         wl->vt = open(buf, O_RDWR|O_CLOEXEC|O_NONBLOCK);
> --
> 1.9.1
>
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/wayland-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/wayland-devel/attachments/20150701/9c3f18c1/attachment.html>


More information about the wayland-devel mailing list