[PATCH weston] input: pass the global touch coordinates to the touch grab

Daniel Stone daniel at fooishbar.org
Wed Jul 8 04:25:08 PDT 2015


Hi,

On 8 July 2015 at 09:55, Giulio Camuffo <giuliocamuffo at gmail.com> wrote:
> @@ -1552,10 +1558,7 @@ notify_touch(struct weston_seat *seat, uint32_t time, int touch_id,
>                 if (touch->num_tp == 1) {
>                         ev = weston_compositor_pick_view(ec, x, y, &sx, &sy);
>                         weston_touch_set_focus(touch, ev);
> -               } else if (touch->focus) {
> -                       ev = touch->focus;
> -                       weston_view_from_global_fixed(ev, x, y, &sx, &sy);
> -               } else {
> +               } else if (!touch->focus) {
>                         /* Unexpected condition: We have non-initial touch but
>                          * there is no focused surface.
>                          */

This change looked iffy to me - I thought it might be a sly way to
give each touch its own independent focus - but is fine since we no
longer need the temporary view for anything other than picking sx/sy,
and we don't need sx/sy anymore.

Reviewed-by: Daniel Stone <daniels at collabora.com>

Cheers,
Daniel


More information about the wayland-devel mailing list