[PATCH weston v3 01/11] compositor: introduce struct weston_backend

[Pekka Paalanen]

On Sat, 27 Jun 2015 14:07:41 +0300
Giulio Camuffo <giuliocamuffo at gmail.com> wrote:

> This is a preliminary change for libweston, with no functional modifications.
> Separate the backends and the core weston_compositor struct, by creating
> the weston_compositor in the main(), and having the various backends extend
> the weston_backend struct, an instance of which is returned by the backend
> entry point.
> This enable us to logically separate the compositor core from the backend,
> allowing the core to be extended without messing with the backends.
> ---
>  src/compositor-drm.c      | 654 +++++++++++++++++++++++-----------------------
>  src/compositor-fbdev.c    | 165 ++++++------
>  src/compositor-headless.c | 106 ++++----
>  src/compositor-rdp.c      | 159 +++++------
>  src/compositor-rpi.c      | 148 +++++------
>  src/compositor-wayland.c  | 371 +++++++++++++-------------
>  src/compositor-x11.c      | 554 ++++++++++++++++++++-------------------
>  src/compositor.c          |  29 +-
>  src/compositor.h          |  16 +-
>  9 files changed, 1123 insertions(+), 1079 deletions(-)

Hi,

I spotted a couple of mistakes:

- in headless_backend_create() in the failure path, call to
  weston_compositor_shutdown() as lost

- in rpi_backend_init(), the call to weston_compositor_init() was lost,
  and the related error path with it

Giulio fixed these, and I pushed the fixed patch with my R-b:
   5a75a41..954f183  master -> master


Thanks,
pq