[PATCH weston] shell: Switch middle and right mouse bindings

Bryce Harrington bryce at osg.samsung.com
Thu Jul 16 19:36:41 PDT 2015


On Fri, Jun 26, 2015 at 01:57:44PM +1000, Peter Hutterer wrote:
> On Thu, Jun 25, 2015 at 04:03:30PM -0500, Derek Foreman wrote:
> > Currently rotate is on the right mouse button and resize is on the middle.
> > 
> > As fantastic as rotating windows is, it's probably nicer to have resize on
> > the right button, especially for anyone with only 2 buttons.
> > 
> > Signed-off-by: Derek Foreman <derekf at osg.samsung.com>
> 
> heresy! I think you should put wobble on the right button
> 
> Reviewed-by: Peter Hutterer <peter.hutterer at who-t.net>

Guess no one else has an opinion on this one?  Seems fine to me, so...

Pushed:
To ssh://git.freedesktop.org/git/wayland/weston
   6bc33d6..2217f3f  master -> master

 
> Cheers,
>    Peter
> 
> > ---
> >  desktop-shell/shell.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/desktop-shell/shell.c b/desktop-shell/shell.c
> > index 0fe4658..e427c62 100644
> > --- a/desktop-shell/shell.c
> > +++ b/desktop-shell/shell.c
> > @@ -6405,14 +6405,14 @@ shell_add_bindings(struct weston_compositor *ec, struct desktop_shell *shell)
> >  	weston_compositor_add_button_binding(ec, BTN_LEFT, mod, move_binding,
> >  					     shell);
> >  	weston_compositor_add_touch_binding(ec, mod, touch_move_binding, shell);
> > -	weston_compositor_add_button_binding(ec, BTN_MIDDLE, mod,
> > +	weston_compositor_add_button_binding(ec, BTN_RIGHT, mod,
> >  					     resize_binding, shell);
> >  	weston_compositor_add_button_binding(ec, BTN_LEFT,
> >  					     mod | MODIFIER_SHIFT,
> >  					     resize_binding, shell);
> >  
> >  	if (ec->capabilities & WESTON_CAP_ROTATION_ANY)
> > -		weston_compositor_add_button_binding(ec, BTN_RIGHT, mod,
> > +		weston_compositor_add_button_binding(ec, BTN_MIDDLE, mod,
> >  						     rotate_binding, NULL);
> >  
> >  	weston_compositor_add_key_binding(ec, KEY_TAB, mod, switcher_binding,
> > -- 
> > 2.1.4
> > 
> > _______________________________________________
> > wayland-devel mailing list
> > wayland-devel at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/wayland-devel
> > 
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/wayland-devel


More information about the wayland-devel mailing list