[PATCH weston v7 0/3] Refactored simple unit/integration test framework and corresponding test program.

Pekka Paalanen ppaalanen at gmail.com
Fri Jul 17 03:35:10 PDT 2015


On Wed, 15 Jul 2015 19:22:40 -0700
"Jon A. Cruz" <jonc at osg.samsung.com> wrote:

> Here is yet another re-worked version of the patch adding unit testing
> framework and corresponding separation. This drops the higher-level waycheck
> program and focuses on the first two steps of adding zunitc and converting
> the config-parser test.
> 
> Changes since v6:
> - Incorporated review feedback.
> - Use of forward declarations dropped in zuc_junit_reporter.c.
> - Note added to README in regards to `make doc`

Hi Jon,

my comments are mostly addressed, so I have pushed this:
   315476f..179c186  master -> master


Since 'make' does not do 'make doc', shouldn't we hook up 'make doc' as
part of 'make distcheck'? So that when distcheck does the test-build
from the tar-ball, it will also execute 'make doc' to see if it fails.


Thanks,
pq

> Changes since v5:
> - Reduced to just the core framework and a test converted to it.
> - Added explicit configuration option for junit/libxml2 use.
> - Refactored to minimize forward declarations.
> - Added zuctest to 'make check'
> - Hooked doxygen generation into build as 'make doc'
> - Removed non-fatal ZUC_EXPECT_* macros
> - Added ZUC_ASSERTG_* macros to allow use of goto for cleanup.
> 
> Changes since v4:
> - Changed junit reporter to use libxml2 for writing XML istead of doing so
>   directly.
> 
> Changes since v3:
> - Cleaned up formatting of return types linebreaks and other misc style
>   issues.
> - Many fixes from review comments on prior versions.
> - Clarified test macro parameter names.
> - Added test macros for NULL/non-NULL and C-style string comparison.
> - Extended fixture construction to facilitate layering Weston-specific
>   fixtures.
> - Track formats supported by wl_shm.
> - Added convenience routines to capture running program name.
> - Updated fixture construction, including being able to specify the Wayland
>   instance to connect to.
> - Reduced Doxygen config files to non-defaults only.
> - Relocated Doxygen specific input files to match Wayland structure.
> 
> Jon A. Cruz (3):
>   Enables output in the JUnit XML format.
>   Converted the config parser test to the new framework.
>   Adding doxygen setup and info for the testing framework.
> 
>  .gitignore                            |   2 +
>  Makefile.am                           |  40 ++-
>  README                                |   6 +
>  configure.ac                          |  45 ++++
>  doc/doxygen/devtools.dox              |  51 ++++
>  doc/doxygen/tooldev.doxygen.in        |  11 +
>  doc/doxygen/tools.dox                 |  31 +++
>  doc/doxygen/tools.doxygen.in          |  10 +
>  doc/doxygen/tools_arch_new.gv         |  85 ++++++
>  doc/doxygen/tools_arch_old.gv         |  53 ++++
>  tests/config-parser-test.c            | 371 ++++++++++++++++++++++-----
>  tools/zunitc/src/zuc_junit_reporter.c | 470 ++++++++++++++++++++++++++++++++++
>  tools/zunitc/src/zuc_junit_reporter.h |  38 +++
>  tools/zunitc/src/zunitc_impl.c        |  17 ++
>  14 files changed, 1169 insertions(+), 61 deletions(-)
>  create mode 100644 doc/doxygen/devtools.dox
>  create mode 100644 doc/doxygen/tooldev.doxygen.in
>  create mode 100644 doc/doxygen/tools.dox
>  create mode 100644 doc/doxygen/tools.doxygen.in
>  create mode 100644 doc/doxygen/tools_arch_new.gv
>  create mode 100644 doc/doxygen/tools_arch_old.gv
>  create mode 100644 tools/zunitc/src/zuc_junit_reporter.c
>  create mode 100644 tools/zunitc/src/zuc_junit_reporter.h
> 



More information about the wayland-devel mailing list