[PATCH v2 weston 0/4] Some zoom fixes

Derek Foreman derekf at osg.samsung.com
Thu Jul 23 12:55:11 PDT 2015

Previously I sent a series that fixed some problems with zoom, but also
changed zoom behaviour in potentially controversial ways (and in did
it in compositor instead of shell, which is probably not great).

This is a rebase of the first few mostly non-invasive patches from the
series, skipping most bits that change behaviour. The reason I'm
reposting this now is I discovered that we still have a crash problem
with zoom - when the first seat has no pointer and you initiate zoom
from any other seat, the compositor crashes. That's fixed in the
final patch of the series.

The major functional change here is that zoom will follow the pointer
of the seat that initiated the zoom now, instead of always following
the first seat's pointer.

The easy way out is to disable zoom if the primary seat has no pointer,
I'll do that if this series is met with unfavorable review. :)

Derek Foreman (4):
  zoom: Change zoom->active to a bool
  zoom: Call weston_output_activate_zoom() appropriately
  zoom: Rename zoom_area_center_from_pointer to
  zoom: Store the seat that initiated a zoom

 desktop-shell/shell.c |  7 +++++--
 src/compositor.h      |  6 ++++--
 src/zoom.c            | 33 ++++++++++++++++-----------------
 3 files changed, 25 insertions(+), 21 deletions(-)


More information about the wayland-devel mailing list