[PATCH weston v2 3/5] compositor: Emit wl_pointer_gesture_* events on libinput gesture events

[Jonas Ådahl]

On Wed, Jul 29, 2015 at 10:38:11AM -0700, Bill Spitzak wrote:
> On Tue, Jul 28, 2015 at 11:59 PM, Jonas Ådahl <jadahl at gmail.com> wrote:
> 
> > On Thu, Jul 23, 2015 at 07:00:29PM +0200, Carlos Garnacho wrote:
> > > The translation is fairly straightforward so far, it would be convenient
> > > if gestures went through the pointer grab interface, but this is not done
> > > at the moment.
> >
> 
> This will send the events to the pointer-grab, it's just that they don't
> cause a grab. I would argue that fixing this is much more than just
> "convenient", it is pretty vital if there is more than one client.

Events will still be sent to the focused client. It's more an
implementation detail to make it possible for grabs to handle gesture
events in a non-default way.

> 
> This seems to be producing a lot of redundant code. Could the client api be
> more like "here is a libinput gesture event"? Then wayland would not have
> to be updated with every new gesture event. And in many cases the client
> will be much easier to write if there is a single called function and the
> gesture is identified by an enumeration.

We are not going to just provide libinput events via Wayland. It simply
doesn't work. Also the Wayland protocol is different and needs to be
different because it has to deal with protocol objects, destruction etc.


Jonas