[PATCH v7 weston 17/17] input: Don't test keyboard/pointer/touch pointers

Bryce Harrington bryce at osg.samsung.com
Fri Jul 31 15:20:25 PDT 2015

On Thu, Jul 30, 2015 at 09:40:56AM +0800, Jonas Ådahl wrote:
> On Wed, Jul 15, 2015 at 01:00:48PM -0500, Derek Foreman wrote:
> > Keyboards and pointers aren't freed when devices are removed, so we should
> > really be testing keyboard_device_count and pointer_device_count in most
> > cases, not the actual pointers. Otherwise we end up with different
> > behaviour after removing a device than we had before it was inserted.
> > 
> > This commit renames the touch/keyboard/pointer pointers and adds helper
> > functions to get them that hide this complexity and return NULL when
> > *_device_count is 0.
> > 
> > Signed-off-by: Derek Foreman <derekf at osg.samsung.com>
> With the nit higher up and this one fixed, this and the other left in
> this series are Reviewed-by: Jonas Ådahl <jadahl at gmail.com>

Thanks for reviewing the set.

To ssh://git.freedesktop.org/git/wayland/weston
   d956379..1281a36  master -> master

More information about the wayland-devel mailing list