[PATCH wayland] wayland-client : Fix queue_release not to call proxy_destroy

Jonas Ã…dahl jadahl at gmail.com
Fri Jul 31 17:22:46 PDT 2015


On Fri, Jul 31, 2015 at 02:22:03PM -0700, Bill Spitzak wrote:
> On Fri, Jul 31, 2015 at 2:02 AM, Elvis Lee <kwangwoong.lee at lge.com> wrote:
> 
> >
> > +               proxy_destroyed = !!(proxy->flags &
> > WL_PROXY_FLAG_DESTROYED);
> > +
> > +               proxy->refcount--;
> > +               if (proxy_destroyed && !proxy->refcount)
> > +                       free(proxy);
> >
> 
> It seems like you don't need the temporary, and could put the test of the
> flag directly in the if statement?

I think the way Elvis already did it is better.

Jonas


More information about the wayland-devel mailing list