Release blockers for 1.8? (was Re: scanner: don't emit the extern declarations for external types)

Bryce Harrington bryce at osg.samsung.com
Mon Jun 1 23:55:55 PDT 2015


On Mon, Jun 01, 2015 at 11:53:23AM +0300, Pekka Paalanen wrote:
> On Mon, 1 Jun 2015 09:55:09 +0200 Arnaud Vrac <rawoul at gmail.com> wrote:
> > On Thu, May 28, 2015 at 6:30 PM, Giulio Camuffo <giuliocamuffo at gmail.com> wrote:
> > > We were emitting the extern declarations of all types used in the protocol,
> > > even if not defined in it. This caused warnings to be produced when using
> > > the -Wredundant-decls compiler flag when building an extension that uses
> > > e.g. wl_surface. However we only need the extern declarations if the
> > > protocol defines a factory for those external interfaces. That is a
> > > bad design and can be however done by including the dependent protocol
> > > header first.
> > > So only emit the extern declarations for the types that the protocol
> > > actually defines, this restoring the behavior we were using in 1.7.
> > >
> > > Fixes https://bugs.freedesktop.org/show_bug.cgi?id=90677
> > > ---
...
> > Tested-by: Arnaud Vrac <rawoul at gmail.com>
> 
> Pushed:
>    c19d5e1..f0be757  master -> master

Noted, this closes the one remaining release blocker I'm aware of.
Any other out-standing patches?

If I don't hear otherwise within the next 12 hrs, I'll be cutting the
1.8.0 release tomorrow as planned.

If there's interest, I can be convinced to do a 1.8.1 stable release in
a month's time for bugfixes.

Bryce


More information about the wayland-devel mailing list