[PATCH libinput 1/4] test: fix litest_log() when libunwind is missing

Hans de Goede hdegoede at redhat.com
Fri Jun 5 02:38:07 PDT 2015


Hi,

On 05-06-15 08:41, Peter Hutterer wrote:
> Previous expansion had side-effects when litest_log was called in an if
> condition without {}
>
> Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>

The entire set looks good to me:

Reviewed-by: Hans de Goede <hdegoede at redhat.com>

Regards,

Hans


> ---
>   test/litest.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/test/litest.c b/test/litest.c
> index c9c17d0..0e2cb96 100644
> --- a/test/litest.c
> +++ b/test/litest.c
> @@ -61,8 +61,8 @@ const char *filter_group = NULL;
>   #define litest_log(...) fprintf(stderr, __VA_ARGS__)
>   #define litest_vlog(format_, args_) vfprintf(stderr, format_, args_)
>   #else
> -#define litest_log(...) /* __VA_ARGS__ */
> -#define litest_vlog(...) /* __VA_ARGS__ */
> +#define litest_log(...) { /* __VA_ARGS__ */ }
> +#define litest_vlog(...) { /* __VA_ARGS__ */ }
>   #endif
>
>   #ifdef HAVE_LIBUNWIND
>


More information about the wayland-devel mailing list