[PATCH weston] compositor: Respect WESTON_BUILD_DIR env var in weston_load_module

Jon A. Cruz jonc at osg.samsung.com
Fri Jun 5 12:15:12 PDT 2015


On 06/05/2015 08:07 AM, Derek Foreman wrote:
> We were loading modules out of the system dirs unconditionally, so
> tests that loaded modules would use the system ones, or fail if
> they weren't installed.
> 
> Signed-off-by: Derek Foreman <derekf at osg.samsung.com>
> ---
> 
>  src/compositor.c | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/src/compositor.c b/src/compositor.c
> index 8f02b4d..0a4186e 100644
> --- a/src/compositor.c
> +++ b/src/compositor.c
> @@ -4906,15 +4906,19 @@ on_caught_signal(int s, siginfo_t *siginfo, void *context)
>  WL_EXPORT void *
>  weston_load_module(const char *name, const char *entrypoint)
>  {
> +	const char *builddir = getenv("WESTON_BUILD_DIR");


There's something 'off' here about the environment variable. However
it's not really about this patch but the variable in general. I'll try
to pinpoint what's bothering me in the overall use and follow up. Might
just be choice of name and reusing a term from a slightly different
context...

-- 
Jon A. Cruz - Senior Open Source Developer
Samsung Open Source Group
jonc at osg.samsung.com


More information about the wayland-devel mailing list