[PATCH weston] don't attempt to start input method if path is empty

Peter Hutterer peter.hutterer at who-t.net
Tue Jun 9 15:48:01 PDT 2015


On Tue, Jun 09, 2015 at 03:00:26PM -0700, Jon A. Cruz wrote:
> Instead of a full strcmp against an empty string, could we just check
> the first char?
> 
>     if (!text_backend->input_method.path[0])

does this really gain us anything worthwhile?

Cheers,
   Peter

> On 06/09/2015 01:28 PM, Murray Calavera wrote:
> > This allows a user to explicitly disable the input
> > method by setting path to blank;
> > 
> > Signed-off-by: Murray Calavera <murray.calavera at gmail.com>
> > ---
> >  src/text-backend.c | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/src/text-backend.c b/src/text-backend.c
> > index 64a3c1b..3c349d4 100644
> > --- a/src/text-backend.c
> > +++ b/src/text-backend.c
> > @@ -957,6 +957,9 @@ launch_input_method(struct text_backend *text_backend)
> >  	if (!text_backend->input_method.path)
> >  		return;
> >  
> > +	if (strcmp(text_backend->input_method.path, "") == 0)
> > +		return;
> > +
> >  	if (text_backend->input_method.process.pid != 0)
> >  		return;
> >  
> > 
> 


More information about the wayland-devel mailing list