[PATCH weston v5 4/6] Enables output in the JUnit XML format.

[Quentin Glidic]

On 2015-06-21 00:47, Jon A. Cruz wrote:
> diff --git a/configure.ac b/configure.ac
> index e047fd5..4a89819 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -264,6 +264,11 @@ if test "x$cairo_modules" = "xcairo-glesv2"; then
>  AC_DEFINE([USE_CAIRO_GLESV2], [1], [Use the GLESv2 GL cairo backend])
>  fi
>  
> +PKG_CHECK_MODULES(LIBXML2, [libxml-2.0 >= 2.6],
> +			   [AC_DEFINE(HAVE_LIBXML2, 1, [Define if libxml2 is available]) have_libxml2=yes],
> +			   have_libxml2=no)
> +AM_CONDITIONAL(HAVE_LIBXML2, [test "x$have_libxml2" = xyes])
> +

Please do not add more full automagic dependencies. Either add a
configure switch to force-disable the dependency or make it a mandatory one.


>  PKG_CHECK_MODULES(PIXMAN, [pixman-1])
>  PKG_CHECK_MODULES(PNG, [libpng])
>  PKG_CHECK_MODULES(WEBP, [libwebp], [have_webp=yes], [have_webp=no])
> @@ -557,5 +562,6 @@ AC_MSG_RESULT([
>  	LCMS2 Support			${have_lcms}
>  	libwebp Support			${have_webp}
>  	libunwind Support		${have_libunwind}
> +	libxml2 Support			${have_libxml2}
>  	VA H.264 encoding Support	${have_libva}
>  ])

In case you add a switch, you may rename the variables to ENABLE_LIBXML2
(no HAVE_). Or maybe ENABLE_JUNIT_REPORTER.

-- 

Quentin “Sardem FF7” Glidic