[PATCH weston] compositor: Separate hardcoded backend related code from compositor

Pekka Paalanen ppaalanen at gmail.com
Tue Jun 23 04:57:22 PDT 2015


On Tue, 23 Jun 2015 14:14:53 +0300
Giulio Camuffo <giuliocamuffo at gmail.com> wrote:

> Hi,
> 
> This kinda goes in the opposite direction to my libweston patches. In
> that series i move the command line handling away from the backends
> code to make them work in multiple compositors. This moves even more
> compositor-specific stuff in the backends so we need to decide if we
> want this or libweston.

We want libweston.

> 2015-06-23 13:29 GMT+03:00 JoonCheol Park <jooncheol at gmail.com>:
> > Instead of adding available backends and usage outputs at build time,
> > this patch finds all available backend plugins in MODULEDIR and prints
> > them. It also prints usage output for selected backend by calling
> > "backend_usage()" in the plugin.
> >
> > By this patch, we can remove all hardcode for backends from compositor.
> > 3rd party backend plugin can be listed in help output. Backend developer
> > can freely add additional description for backend.
> >
> > Signed-off-by: JoonCheol Park <jooncheol at gmail.com>
> > ---
> >  src/compositor-drm.c      |  11 ++++
> >  src/compositor-fbdev.c    |   9 +++
> >  src/compositor-headless.c |  11 ++++
> >  src/compositor-rdp.c      |  15 +++++
> >  src/compositor-rpi.c      |  12 ++++
> >  src/compositor-wayland.c  |  14 +++++
> >  src/compositor-x11.c      |  13 +++++
> >  src/compositor.c          | 141 ++++++++++++----------------------------------
> >  src/compositor.h          |   3 +
> >  9 files changed, 125 insertions(+), 104 deletions(-)

JoonCheol, any particular reason you are proposing this?
Are you building external backends?

AFAIK the Weston SDK (the installed headers) for external plugins never
supported external backends, so I'm curious.

We are going in the direction of backends becoming libweston internal
details, not something you can plug and switch arbitrarily, at least
for the middle-term.


Thanks,
pq


More information about the wayland-devel mailing list