[PATCH weston v5 2/6] By default, stop test execution if unrecognized parameters are encountered.

[Pekka Paalanen]

On Sat, 20 Jun 2015 15:47:44 -0700
"Jon A. Cruz" <jonc at osg.samsung.com> wrote:

> Signed-off-by: Jon A. Cruz <jonc at osg.samsung.com>
> ---
>  tools/zunitc/src/main.c | 11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/zunitc/src/main.c b/tools/zunitc/src/main.c
> index cc86185..8179807 100644
> --- a/tools/zunitc/src/main.c
> +++ b/tools/zunitc/src/main.c
> @@ -41,7 +41,16 @@ main(int argc, char* argv[])
>  	int rc = zuc_initialize(&argc, argv, &helped);
>  
>  	if ((rc == EXIT_SUCCESS) && !helped) {
> -		rc = ZUC_RUN_TESTS();
> +		/* Stop if any unrecognized parameters were encountered. */
> +		if (argc > 1) {
> +			printf("%s: unrecognized option '%s'\n",
> +			       argv[0], argv[1]);
> +			printf("Try '%s --help' for more information.\n",
> +			       argv[0]);
> +			rc = EXIT_FAILURE;
> +		} else {
> +			rc = ZUC_RUN_TESTS();
> +		}
>  	}
>  
>  	zuc_cleanup();

Hi Jon,

looks good. Any reason it's a follow-up patch rather than squashed into
patch 1 which creates main.c?

I suppose it could also print all remaining options.


Thanks,
pq