[PATCH weston 0/3] Rework the launcher infrastructure

[David Herrmann]

Hi

On Thu, Mar 19, 2015 at 4:04 AM, Jasper St. Pierre
<jstpierre at mecheye.net> wrote:
> Since the time that the logind launcher integration was written, it has
> since gained a lot of features that mean that we don't have to touch
> the TTY or VT ioctls ourselves.
>
> Refactor the launcher system so that we have three different
> implementations of the launcher system, tried in this order:
>
>   1. logind, which uses the systemd-logind APIs to manage VTs and TTYs
>      and devices for us cooperatively.
>
>   2. weston-launch, which uses our legacy setuid helper to manage the
>      same devices.
>
>   3. Direct, which is only used when you are root, for small embedded
>      systems.
>
> The first two patches in this series should not have any major changes
> in behavior, but is simply a giant refactor to make this code more
> understandable and maintainable.
>
> The third patch upgrades our logind launcher to the latest APIs.
> Switching to the new logind APIs on logind also adds the new ability
> that a smoother handover can be done from display managers like gdm,
> where we can have a VT allocated to us instead of requiring that we're
> opened on our own VT.
>
> There should not be any regressions in existing behavior.
>
> Cc: David Herrmann <dh.herrmann at gmail.com>
> Cc: Ray Strode <rstrode at redhat.com>
>
> Jasper St. Pierre (3):
>   launcher: Rename logind-util to launcher-logind
>   launcher: Split out launcher implementations into three distinct ones
>   launcher-logind: Remove old VT switching code, move to
>     SwitchTo/Activate

Looks good to me (especially the last one). I do have some suggestions
to simplify some paths, but I don't think it's worth delaying this
rework. This can all be done later on (and you mostly copied the code
verbatim, anyway). Derek pointed out some issues, but apart from that
I'm fine with the patches.

Thanks
David