[PATCH] Enhance wayland-scanner so it can use files for input and output.

Bill Spitzak spitzak at gmail.com
Mon Mar 2 18:36:40 PST 2015


Probably nitpicky as well, but you may also want to add:

- If argc is 3 then use the name as the input file but use stdout for 
the output.

- A filename of "-" leaves it using stdin/out.

Neither of these are very important, just trying to match standard usage 
of other tools.

On 03/02/2015 02:10 AM, Jussi Pakkanen wrote:
> On Mon, Mar 2, 2015 at 9:52 AM, Pekka Paalanen <ppaalanen at gmail.com
> <mailto:ppaalanen at gmail.com>> wrote:
>
>     in addition to the other review commments, I believe the
>     standard way for changing the file association for stdout is to use
>     freopen(). Is there a reason why you didn't use freopen()?
>
>
> The main one is that I did not know freopen existed. :)
>
> Since there are several issues raised, I'll submit a new revision of
> this patch soon.
>
>
>
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/wayland-devel
>


More information about the wayland-devel mailing list