weston build on older linuxes, where CLOCK_BOOTTIME is not available. trivial patch attached.

Pekka Paalanen ppaalanen at gmail.com
Tue Mar 3 06:02:35 PST 2015


On Thu, 26 Feb 2015 00:12:32 +0000
Volker Eckert <volrek at gmail.com> wrote:

> hi all,
> 
> i can successfully build weston on debian 7 (kernel 3.2.0-4, glibc 2.13-38), if i make the use of CLOCK_BOOTTIME conditional on its availabilty (see patch). this might also apply on other older systems (certainly centos 6.5 is affected) and in terms of portability it probably makes sense to #ifdef all of the linux specific ones in the first place (?)
> 

Hi,

oh right. Could you move the #ifdefs to the beginning of the line, not
indented, and post the patch inline in proper git style, please?

With that fixed:
Reviewed-by: Pekka Paalanen <pekka.paalanen at collabora.co.uk>

I'm not sure it makes sense to #ifdef everything Linux specific, we use
stuff like signalfd and timerfd among other things, and epoll. Making
Weston portable outside Linux would be a much much bigger task, and I'm
not sure it is worth it.


Thanks,
pq


More information about the wayland-devel mailing list