[PATCH libinput 1/3] test: fix/disable two tap test for semi-mt devices

[Hans de Goede]

Hi Peter,

Thanks for working on this. You're timing wrt MM_TO_DPI_NORMALIZED introduction
is excellent as I need something similar for my pinch gesture work.

I've a couple of remarks, so I'm going to reply to each patch separately.

On 05-03-15 22:45, Peter Hutterer wrote:
> On a semi-mt device lifting slot 0 before slot 1 makes slots 1 become slot 0
> (with the matching coordinate jump), potentially triggering the tap movement
> threshold.
>
> On one test we can just swap the release order, the other test we need to
> disable (the _inverted version of this test tests the other order anyway).
>
> Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>

Looks good:

Reviewed-by: Hans de Goede <hdegoede at redhat.com>

Regards,

Hans

> ---
>   test/touchpad.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/test/touchpad.c b/test/touchpad.c
> index 8077f8e..5c8f579 100644
> --- a/test/touchpad.c
> +++ b/test/touchpad.c
> @@ -2570,8 +2570,8 @@ START_TEST(touchpad_left_handed_tapping_2fg)
>
>   	litest_touch_down(dev, 0, 50, 50);
>   	litest_touch_down(dev, 1, 70, 50);
> -	litest_touch_up(dev, 0);
>   	litest_touch_up(dev, 1);
> +	litest_touch_up(dev, 0);
>
>   	libinput_dispatch(li);
>   	litest_timeout_tap();
> @@ -3356,7 +3356,7 @@ int main(int argc, char **argv) {
>   	litest_add("touchpad:tap", touchpad_2fg_tap_n_drag, LITEST_TOUCHPAD, LITEST_SINGLE_TOUCH);
>   	litest_add("touchpad:tap", touchpad_2fg_tap_n_drag_3fg_btntool, LITEST_TOUCHPAD, LITEST_SINGLE_TOUCH|LITEST_APPLE_CLICKPAD);
>   	litest_add("touchpad:tap", touchpad_2fg_tap_n_drag_3fg, LITEST_TOUCHPAD, LITEST_SINGLE_TOUCH);
> -	litest_add("touchpad:tap", touchpad_2fg_tap, LITEST_TOUCHPAD, LITEST_SINGLE_TOUCH);
> +	litest_add("touchpad:tap", touchpad_2fg_tap, LITEST_TOUCHPAD, LITEST_SINGLE_TOUCH|LITEST_SEMI_MT);
>   	litest_add("touchpad:tap", touchpad_2fg_tap_inverted, LITEST_TOUCHPAD, LITEST_SINGLE_TOUCH);
>   	litest_add("touchpad:tap", touchpad_1fg_tap_click, LITEST_TOUCHPAD|LITEST_BUTTON, LITEST_CLICKPAD);
>   	litest_add("touchpad:tap", touchpad_2fg_tap_click, LITEST_TOUCHPAD|LITEST_BUTTON, LITEST_SINGLE_TOUCH|LITEST_CLICKPAD);
>