[PATCH weston 2/8] pixman-renderer: put transformation computation into function

[Pekka Paalanen]

On Fri, 06 Mar 2015 13:31:28 -0600
Derek Foreman <derekf at osg.samsung.com> wrote:

> On 06/03/15 05:03 AM, Pekka Paalanen wrote:
> > From: Pekka Paalanen <pekka.paalanen at collabora.co.uk>
> > 
> > Move the long piece of code computing the end-to-end transformation from
> > repaint_region() into a new function
> > pixman_renderer_compute_transform().
> > 
> > The code itself it not modified.
> > 
> 
> Nice refactor, but the transform patch series posted a while ago
> contains a patch:
> http://patchwork.freedesktop.org/patch/35170/
> 
> that reduces the bits moved into pixman_renderer_compute_transform to
> about 10 lines.
> 
> Do you need those bits in a separate function somewhere or is this just
> a cosmetic refactor?

This is only a cosmetic refactor, so I can be better sure in future
patches that I'm not touching this long piece of convoluted code again.
I am changing the code around that piece.

I did look at that patch in Patchwork and the whole series, but that
particular patch depends on couple of the matrixification patches,
doesn't it? I wasn't comfortable picking those up right now.

Now that I'm looking at that series again, it doesn't look so scary
after all. Still, rebasing it should be pretty easy, right?

The same could be said about my series. Maybe I should just take and
land the few first patches from there...


Thanks,
pq

> > Because the number of moved lines is so big, git-diff will show the
> > changes in the context instead of the moved lines.
> > 
> > Signed-off-by: Pekka Paalanen <pekka.paalanen at collabora.co.uk>
> > ---
> >  src/pixman-renderer.c | 94 +++++++++++++++++++++++++++++----------------------
> >  1 file changed, 53 insertions(+), 41 deletions(-)