[PATCH wayland] server: add helper functions for wl_global

Bill Spitzak spitzak at gmail.com
Mon Mar 9 11:13:20 PDT 2015


On 03/09/2015 06:34 AM, Pekka Paalanen wrote:

> What performance concerns do you have?

I suspect the worry was about allocating and freeing a temporary array, 
but your idea of the caller passing the array avoids it.

I feel like it would be better to reduce the number of arguments to only 
a set that there is some possibility the backend may optimize to 
something other than a linear search. My main concern is the "data" as 
there are instances where using NULL is valid and something you would 
search for, and it seems really unlikely a compositor will arrange the 
globals into sets or sorted depending on their data pointer. I'm also 
not sure if anybody would pass a specific version number without also 
passing a specific bind function, though I don't understand enough about 
the version control to be sure.


More information about the wayland-devel mailing list