[PATCH weston v2 00/16] Fix pixman-renderer cropping

[Jason Ekstrand]

Hey pq,
Glad to see this stuff finally look like landing ~1 year later. :-)  My
reviewing ability on this code has decreased substantially since I wrote it
so I'm kind of trusting you to have tested it thuroughly and trusting
myself to have known what I was doing back then.  That said,

Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>

On Tue, Mar 10, 2015 at 7:48 AM, Derek Foreman <derekf at osg.samsung.com>
wrote:

> On 10/03/15 08:01 AM, Pekka Paalanen wrote:
> > From: Pekka Paalanen <pekka.paalanen at collabora.co.uk>
> >
> > Hi,
> >
> > as requested by Derek, here is a revised series from
> >
> http://lists.freedesktop.org/archives/wayland-devel/2015-March/020440.html
> >
> > The major addition to the series is that I pulled selected patches from
> >
> http://lists.freedesktop.org/archives/wayland-devel/2014-October/017801.html
> > recently rebased by Derek in
> > https://github.com/ManMower/weston/commits/transforms
> > to the beginning of my series, so that pixman-renderer would have less
> > code to move around.
> >
> > While doing that, I added the zoom cleanups to the very beginning, and
> fixed
> > some fallout from the output matrix changes.
> >
> > Jason, for all patches where you are the author, I'd like to get your
> S-o-b and/or
> > R-b. I did do some minor modifications, those are noted in the commit
> messages.
> >
> > Derek, I'd appreciate R-b's, and S-o-b for the patch you authored in this
> > series. I have addressed your review comments from the last time, so some
> > patches already have your R-b, but wouldn't hurt to have a quick look
> again.
> >
> > The series is also available in
> > http://cgit.collabora.com/git/user/pq/weston.git/log/?h=pixmancomplex-3
> >
> >
> > Thanks,
> > pq
> >
> > Derek Foreman (1):
> >   compositor: use weston_matrix_transform for
> >     weston_output_transform_coordinate
>
> S-O-B me.
>
> >
> > Jason Ekstrand (4):
> >   Use pixel coordinates for weston_output.matrix
> >   zoom: Use pixels instead of GL coordinates
> >   compositor: Add surface-to-buffer and buffer-to-surface matrices
> >   pixman-renderer: simplify the output-to-buffer matrix computation
>
> Since we're not allowing zoom at all, I guess we could continue to
> disallow zoom across this patch instead of rendering funny stuff.
>
> Personally, I'm not too concerned about cosmetic brokenness here since
> it's about to be fixed and didn't work previously. :)
>
> >
> > Pekka Paalanen (11):
> >   zoom: remove animation_xy as unused
> >   zoom: remove unused args from weston_zoom_transition
> >   rpi-renderer: minimal fix to zoom coordinates
>
> Patch looks good, but I have no rpi to test.
>
> All patches Reviewed-By: Derek Foreman <derekf at osg.samsung.com>
>
> No further comments. :)
>
> >   compositor: add weston_surface_to_buffer_region()
> >   pixman-renderer: refactor transformation computation
> >   pixman-renderer: refactor into region_intersect_only_translation()
> >   pixman-renderer: add view_transformation_is_translation()
> >   pixman-renderer: change repaint_region() arguments
> >   pixman-renderer: move code to draw_view_translated()
> >   pixman-renderer: implement source clipping
> >   pixman-renderer: implement view scissor
> >
> >  src/compositor.c      | 292 ++++++++++++++++++-------------
> >  src/compositor.h      |  18 +-
> >  src/gl-renderer.c     |  14 +-
> >  src/pixman-renderer.c | 475
> +++++++++++++++++++++++++++++---------------------
> >  src/rpi-renderer.c    |  10 +-
> >  src/zoom.c            |  98 +++--------
> >  6 files changed, 493 insertions(+), 414 deletions(-)
> >
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/wayland-devel/attachments/20150310/68f24387/attachment.html>