[PATCH weston] xwayland: wm: fix an invalid read

[Giulio Camuffo]

Oops, that looks broken indeed.

Reviewwed-by: Giulio Camuffo <giuliocamuffo at gmail.com>

2015-03-11 10:36 GMT+02:00 Ryo Munakata <ryomnktml at gmail.com>:
> This `for` statement needs corresponding braces.
>
> Signed-off-by: Ryo Munakata <ryomnktml at gmail.com>
> ---
>  xwayland/window-manager.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/xwayland/window-manager.c b/xwayland/window-manager.c
> index ec3dab9..ad608b7 100644
> --- a/xwayland/window-manager.c
> +++ b/xwayland/window-manager.c
> @@ -471,13 +471,14 @@ weston_wm_window_read_properties(struct weston_wm_window *window)
>                 case TYPE_NET_WM_STATE:
>                         window->fullscreen = 0;
>                         atom = xcb_get_property_value(reply);
> -                       for (i = 0; i < reply->value_len; i++)
> +                       for (i = 0; i < reply->value_len; i++) {
>                                 if (atom[i] == wm->atom.net_wm_state_fullscreen)
>                                         window->fullscreen = 1;
>                                 if (atom[i] == wm->atom.net_wm_state_maximized_vert)
>                                         window->maximized_vert = 1;
>                                 if (atom[i] == wm->atom.net_wm_state_maximized_horz)
>                                         window->maximized_horz = 1;
> +                       }
>                         break;
>                 case TYPE_MOTIF_WM_HINTS:
>                         memcpy(&window->motif_hints,
> --
> 2.3.2
>
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/wayland-devel