[PATCH weston v2 2/6] compositors: Wrap clock_gettime() usage

[Pekka Paalanen]

On Mon, 22 Dec 2014 16:09:15 -0600
Derek Foreman <derekf at osg.samsung.com> wrote:

> In preparation for a future patch which allows test clients to control
> the presentation clock, we wrap any clock_gettime() of the presentation
> clock in weston_compositor_presentation_clock_gettime().
> 
> Signed-off-by: Derek Foreman <derekf at osg.samsung.com>

Hi,

yeah, this patch looks good.

I'm finishing the repaint scheduling patches right now, and I'd want to
make this wrapping part of that series. Bikeshedding a bit, I'd like to
call this function weston_compositor_read_presentation_clock() to go
with weston_compositor_set_presentation_clock() etc.

I also need to drop the test mode parts, so we'll get a patch which
only wraps the stuff into a new function but doesn't change any
behaviour.

That said, I do wonder how we're going to deal with the repaint delay
timer that is intended to wait a time period measured in the
presentation clock, when you expose a test protocol to set the
presentation clock time...

Anything I should take into account right now?


Thanks,
pq

> ---
>  src/compositor-drm.c      |  2 +-
>  src/compositor-fbdev.c    |  2 +-
>  src/compositor-headless.c |  2 +-
>  src/compositor-rdp.c      |  2 +-
>  src/compositor-x11.c      |  2 +-
>  src/compositor.c          | 22 ++++++++++++++++++++++
>  src/compositor.h          |  5 +++++
>  7 files changed, 32 insertions(+), 5 deletions(-)