[PATCH weston 3/4] gl-renderer: use eglCreatePlatformWindowSurfaceEXT to get EGLSurfaces

Bill Spitzak spitzak at gmail.com
Thu Mar 19 11:27:26 PDT 2015


On 03/19/2015 07:07 AM, Jonny Lamb wrote:

> -	if (gl_renderer->output_create(&output->base, output->surface,
> +	if (gl_renderer->output_create(&output->base,
> +				       output->surface, output->surface,
>   				       gl_renderer->opaque_attribs,
>   				       &format) < 0) {

I don't see the need for the duplicate arguments here. Both are 
obviously the same value (the xid), it's just that one of the API's 
declares this as EGLNativeWindowType and the other as void*. I think it 
would be best to hide all this ugliness and make output_create take an xid.


More information about the wayland-devel mailing list