[PATCH weston 00/10] platform_base cleanups and review reply

Pekka Paalanen pekka.paalanen at collabora.co.uk
Tue Mar 24 06:33:59 PDT 2015


On Tue, 24 Mar 2015 13:11:59 +0100
Jonny Lamb <jonny.lamb at collabora.co.uk> wrote:

> In reply to Pekka's late review, I've written some more patches to
> address his comments:
> 
> Jonny Lamb (10):
>   compositor-{drm,x11,wayland}: stop including EGL headers here
>   gl-renderer: fix build with --disable-egl
>   gl-renderer: move all EGL_PLATFORM_* defines here
>   compositor-{drm,wayland,x11}: remove useless tests for ->supports
>   gl-renderer: call supports() automatically in create()
>   gl-renderer: provide platform_base fallbacks and remove ifdefs
>   nested-client: include platform.h
>   platform: provide platform_base fallbacks and remove ifdefs
>   platform: remove global variables
>   platform: rename create_egl_window to create_egl_surface
> 
>  clients/nested-client.c   |   6 ++-
>  clients/simple-egl.c      |   6 +--
>  clients/subsurfaces.c     |   6 +--
>  clients/window.c          |   6 +--
>  shared/platform.h         | 106 ++++++++++++++++++++++++++++------------------
>  src/compositor-drm.c      |  14 +-----
>  src/compositor-fbdev.c    |   3 +-
>  src/compositor-wayland.c  |  14 +-----
>  src/compositor-x11.c      |   9 ----
>  src/gl-renderer.c         |  66 +++++++++++++++++++----------
>  src/gl-renderer.h         |  25 +++++++++--
>  tests/buffer-count-test.c |   6 +--
>  12 files changed, 150 insertions(+), 117 deletions(-)
> 

Yup, it's all landable stuff on my behalf.

Thanks,
pq


More information about the wayland-devel mailing list