[PATCH weston v2 1/6] test: Add a compositor test-mode

[Pekka Paalanen]

On Tue, 27 Jan 2015 12:33:19 +0000
Daniel Stone <daniel at fooishbar.org> wrote:

> Hi,
> 
> On 22 December 2014 at 22:08, Derek Foreman <derekf at osg.samsung.com> wrote:
> > diff --git a/protocol/wayland-test.xml b/protocol/wayland-test.xml
> > index 18b6625..292abe9 100644
> > --- a/protocol/wayland-test.xml
> > +++ b/protocol/wayland-test.xml
> > @@ -26,7 +26,7 @@
> >      THIS SOFTWARE.
> >    </copyright>
> >
> > -  <interface name="wl_test" version="1">
> > +  <interface name="wl_test" version="2">
> >      <request name="move_surface">
> >        <arg name="surface" type="object" interface="wl_surface"/>
> >        <arg name="x" type="int"/>
> > --- a/tests/weston-test.c
> > +++ b/tests/weston-test.c
> > @@ -235,6 +235,14 @@ get_n_buffers(struct wl_client *client, struct wl_resource *resource)
> >         wl_test_send_n_egl_buffers(resource, n_buffers);
> >  }
> >
> > +static void
> > +enable_test_mode(struct wl_client *client, struct wl_resource *resource)
> > +{
> > +       struct weston_test *test = wl_resource_get_user_data(resource);
> > +
> > +       weston_compositor_test_mode_enable(test->compositor);
> > +}
> > +
> >  static const struct wl_test_interface test_implementation = {
> >         move_surface,
> >         move_pointer,
> 
> You're bumping the protocol version, but not adding a 'since' tag to
> test_mode_enable, or advertising the new version of the protocol in
> module_init() and verifying that the versions match in bind_test().
> Same comment applies to all later additions in this series.
> 
> Are there any clients which make use of this yet?

Yeh, all true, though this is the scary test extension into Weston's
internals which may vary release by release and no-one outside the
Weston tests/ directory should be accessing these, so I think we could
keep on being sloppy here and forget the versioning.


Thanks,
pq