[PATCH weston 0/6] Add client driven repaint and clock for testing

[Pekka Paalanen]

On Fri, 19 Dec 2014 12:45:44 -0600
Derek Foreman <derekf at osg.samsung.com> wrote:

> This series allows test clients to put the compositor into a new "test mode"
> where the presentation clock is controlled by the client, and the client
> can request a repaint.
> 
> Only the headless compositor supports this for now.
> 
> Derek Foreman (6):
>   test: Add a compositor test-mode
>   compositors: Wrap clock_gettime() usage
>   test: Add clock_settime()
>   compositor: Make repaint loop exit frequently in test mode
>   test: Add client driven repaint
>   compositor-headless: Add test mode
> 
>  protocol/wayland-test.xml |  9 ++++++++-
>  src/compositor-drm.c      |  2 +-
>  src/compositor-fbdev.c    |  2 +-
>  src/compositor-headless.c | 36 +++++++++++++++++++++++++++++++++---
>  src/compositor-rdp.c      |  2 +-
>  src/compositor-x11.c      |  2 +-
>  src/compositor.c          | 43 +++++++++++++++++++++++++++++++++++++++++++
>  src/compositor.h          | 15 +++++++++++++++
>  tests/weston-test.c       | 31 +++++++++++++++++++++++++++++++
>  9 files changed, 134 insertions(+), 8 deletions(-)
> 

This is an interesting idea, which undoubtedly would allow us to test
ever more intricate parts of weston.

However, I wouldn't hold this as a prerequisite to screenshot-based
testing (just in case you do).

Screenshot-based testing should be well implementable without
controlling the clock or the repaint cycle. After a test client has
submitted its requests, and then requests a screenshot, the screenshot
would pend until after the next repaint. Just like the current
screenshooting works.

I'd like to propose to go for screenshot-based first, and clock control
after unless you see some major drawbacks in that. I have a hunch the
clock control won't be as easy as it seems.


Thanks,
pq