[PATCH weston 0/4] Some transform fixes

[Derek Foreman]

On 27/03/15 02:23 AM, Pekka Paalanen wrote:
> On Tue, 24 Mar 2015 22:09:05 -0700
> Bryce Harrington <bryce at osg.samsung.com> wrote:
> 
>> On Tue, Mar 24, 2015 at 11:36:12AM -0500, Derek Foreman wrote:
>>> Zoom broke in 87535e24 "zoom: use pixels instead of gl co-ordinates"
>>> was fixed for some transforms in 0f67941c "compositor: use weston_matrix_transform for weston_output_transform_coordinate"
>>> but that commit broke multiple output nested compositors (x11, wayland)
>>> because it did the inverse transform of what the old function did - which
>>> worked just fine for the case when the transform was identity.
>>>
>>> This series attempts to fix those regressions
>>
>> Reviewed-by: Bryce Harrington <b.harrington at samsung.com>
> 
> R-b me, and pushed.
>    d19e9b0..a5855ad  master -> master
> 
> I think there may still be something funny with zoom & multiple
> outputs. If you try with two outputs on x11 backend, zoom on both, and
> then move the pointer on each output in turn, the motion also affects
> the other output but only in one direction. o_O
> 
> I never tried it before, so I'm not sure how it should work.

FWIW, I think this is how zoom has always worked.  Both heads continue
to track the pointer, but the head that the pointer isn't on only moves
in one direction because it's already at its farthest possible point in
the other axis (ie: if the heads are side by side an the pointer is on
the right head, the left head's zoom position is all the way to the right)

Things get even more confusing with transforms, of course.


> Thanks,
> pq
> 
>>> Derek Foreman (4):
>>>   compositor: Create the inverse of the output matrix
>>>   compositor: fix weston_output_transform_coordinate
>>>   zoom: fix zoom
>>>   pixman-renderer: use pre-computed inverse output matrix
>>>
>>>  src/compositor.c      | 4 +++-
>>>  src/compositor.h      | 2 ++
>>>  src/pixman-renderer.c | 2 +-
>>>  src/zoom.c            | 4 ++--
>>>  4 files changed, 8 insertions(+), 4 deletions(-)
>>>
>>> -- 
>>> 2.1.4
>>>
>>> _______________________________________________
>>> wayland-devel mailing list
>>> wayland-devel at lists.freedesktop.org
>>> http://lists.freedesktop.org/mailman/listinfo/wayland-devel
>> _______________________________________________
>> wayland-devel mailing list
>> wayland-devel at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/wayland-devel
>