[PATCH weston 06/10] protocol: Add test screenshot capability

[Pekka Paalanen]

On Sat, 9 May 2015 14:53:48 +0100
Daniel Stone <daniel at fooishbar.org> wrote:

> Hi,
> 
> On 7 May 2015 at 01:44, Bryce Harrington <bryce at osg.samsung.com> wrote:
> > This adds a capture_screenshot request which returns an image of the
> > screen in the client-supplied wl_buffer for the given display output.
> >
> > A 'done' event is used to indicate when screenshotting has finished and
> > the wl_buffer is ready to be read.
> >
> > Signed-off-by: Bryce Harrington <bryce at osg.samsung.com>
> > ---
> >  protocol/weston-test.xml | 16 ++++++++++++++++
> >  1 file changed, 16 insertions(+)
> >
> > diff --git a/protocol/weston-test.xml b/protocol/weston-test.xml
> > index 643a0c7..35e55ad 100644
> > --- a/protocol/weston-test.xml
> > +++ b/protocol/weston-test.xml
> > @@ -73,6 +73,22 @@
> >      <event name="n_egl_buffers">
> >        <arg name="n" type="uint"/>
> >      </event>
> > +    <request name="capture_screenshot">
> > +      <description summary="records current screen image">
> > +        Records an image of what is currently displayed on a given
> > +        display output, returning the image as a screen_image event.

Hi,

s/screen_image/capture_screenshot_done/?

> > +      </description>
> > +      <arg name="output" type="object" interface="wl_output"
> > +           summary="output to capture from"/>
> > +      <arg name="buffer" type="object" interface="wl_buffer"
> > +           summary="buffer for returning screenshots to the test client"/>
> > +    </request>
> > +    <event name="capture_screenshot_done">
> > +         <description summary="screenshot capture is done">
> > +               The capture_screenshot_done signal is sent when a screenshot has been copied into the
> > +               provided buffer.
> > +         </description>
> > +    </event>
> >    </interface>
> 
> I'd probably lean towards making this a new interface, to be honest,
> to avoid ambiguity or blocking if you want to fire off multiple
> screenshot requests.

Or just a wl_callback to signal the completion?


Thanks,
pq