[PATCH] RDP compositor: fixes for multiple connections, mstsc and FreeRDP master compilation

[Pekka Paalanen]

On Wed,  6 May 2015 10:59:42 +0200
David FORT <rdp.effort at gmail.com> wrote:

> From: Hardening <rdp.effort at gmail.com>
> 
> This patch fixes the problem reported on the mailing list
> (http://lists.freedesktop.org/archives/wayland-devel/2015-January/019575.html).
> All certificate and key paths were not copied when given to FreeRDP, so they
> were freed when the peer was disconnecting. And so the next connection was failing.
> 
> All the initialization stuffs have been moved to the activate callback, as when it is
> called the peer is ready for graphics.
> 
> We also differ the creation of the seat, so that a seat is initialized only the
> peer really do the activation sequence. That helps when mstsc just connects to see
> the certificate, ask if the certificate should be trusted, and then reconnects.
> 
> This patch also adds configuration settings for recent versions of FreeRDP that
> comes with everything disabled. This makes remoteFx functionnal again.
> 
> The patch also handles the skipCompression flag for last FreeRDP versions, that
> allows to skip bulk compression for surfaces that have been already compressed by
> the remoteFx or NS codec.
> 
> This also fixes the compilation against FreeRDP master with callback that now return
> BOOL.
> ---
>  src/compositor-rdp.c | 127 +++++++++++++++++++++++++++++++++++++++------------
>  1 file changed, 97 insertions(+), 30 deletions(-)

Hi,

reading the description, this sounds like it should be 4-5 separate
patches, but you're the RDP-backend maintainer, so if you think it's
fine, I'm not going to argue.

I can only check that the changes are confined to the RDP-backend and
they are not obviously bad, so in that sense:
Acked-by: Pekka Paalanen <pekka.paalanen at collabora.co.uk>

Feel free to push, IIRC you have the rights.


Thanks,
pq