[PATCH] compositor-drm: Add environment variable, WESTON_FORCE_SW_CURSORS to force software cursors

[Pekka Paalanen]

On Wed, 13 May 2015 22:25:31 -0400
nerdopolis <bluescreen_avenger at verizon.net> wrote:

> For some video cards, hardware rendered cursors fail to change properly.
> 
> Add a variable that users can use for these cards when starting Weston.
> 
> Also document in the man page
> 
> This time with all the closing parenthesis, and the correct commit message.
> ---
>  man/weston.man       | 4 ++++
>  src/compositor-drm.c | 5 ++++-
>  2 files changed, 8 insertions(+), 1 deletion(-)

Hi,

it would be much easier to evaluate this patch if you documented
exactly the situation where you needed this: what hardware, what
driver, kernel version, etc.

Also a link to a kernel bug report for the driver in question would be
awesome.

> +	if (getenv("WESTON_FORCE_SW_CURSORS"))
> +	{
> +		ec->cursors_are_broken = 1;
> +	}

Opening brace should be on the same line as 'if'. Except, since there
is only one branch and one statement, you shouldn't use braces at all.


Thanks,
pq