[PATCH wayland] tests: add an headers test

Bill Spitzak spitzak at gmail.com
Wed May 20 15:47:00 PDT 2015


Please don't duplicate the functions in multiple headers!

You could achieve the same result this way so that there is only one 
copy of each function in the headers:

wayland-client-protocol-core.h =
   (the same as you have it, generated by wayland-scanner -c)

wayland-client-protocol.h =
   #include <wayland-client-protocol-core.h>
   #include <wayland-client.h>

However this really is a mess and these extra header files do nothing 
except confuse anybody trying to learn wayland. Would vastly prefer 
making -c the default and requiring the *VERY FEW* programs that no 
longer compile to be patched.

On 05/20/2015 12:38 PM, Giulio Camuffo wrote:

> @@ -85,6 +87,12 @@ protocol/%-server-protocol.h : $(top_srcdir)/protocol/%.xml
>   protocol/%-client-protocol.h : $(top_srcdir)/protocol/%.xml
>   	$(AM_V_GEN)$(MKDIR_P) $(dir $@) && $(wayland_scanner) client-header < $< > $@
>
> +protocol/%-server-protocol-core.h : $(top_srcdir)/protocol/%.xml
> +	$(AM_V_GEN)$(MKDIR_P) $(dir $@) && $(wayland_scanner) server-header -c < $< > $@
> +
> +protocol/%-client-protocol-core.h : $(top_srcdir)/protocol/%.xml
> +	$(AM_V_GEN)$(MKDIR_P) $(dir $@) && $(wayland_scanner) client-header -c < $< > $@
> +



More information about the wayland-devel mailing list