[PATCH] desktop-shell: support an option to use 16 bit color or not, instead of using it by default

[Pekka Paalanen]

On Sat, 23 May 2015 13:10:20 -0400
nerdopolis <bluescreen_avenger at verizon.net> wrote:

> On Friday, May 22, 2015 01:19:58 AM you wrote:
> > On Thu, May 21, 2015 at 11:15:54PM -0400, nerdopolis wrote:

> > > It would be harder to write a whole new test for this...
> > > Weston setting the wallpaper to 16 bit only when compiled with with-cairo=image.
> > > when compiled with-cairo=gl, the wallpaper forcing to RGB565 didn't even work, and it shows up 32 bits...
> > 
> > Huh, interesting.  I thought pq said the only thing cairo-gl affected
> > were a few of the demos.

Was required by, rather than affected. All toytoolkit clients will use
cairo-gl, if Weston is built with cairo-gl support. And this is bad.

> > So, the test will need to include two reference images, one for
> > cairo=image, the other for cairo=gl, and the test will somehow need to
> > discern which one is in use (maybe it's indicated in config.h?)
> >
> Cairo-gl apparently wasn't *supposed* to affect the 16 bit wallpaper not working. I think it might be a bug
> in Weston that cairo-gl is ignoring window_set_preferred_format

Whatever it is, the cairo-gl path is not worth fixing nor testing.

If you want to get rid of the problem on the short term, I'd suggest
modifying toytoolkit such that cairo-gl support is an opt-in feature,
only enabled in demos that really need it (i.e. those that are
currently not even built when --with-cairo=image). That would minimize
the damage from --with-cairo=gl and --with-cairo=glesv2, and give
consistent wallpaper depth.


Thanks,
pq