[PATCH xwayland] xwayland: Throttle our cursor surface updates with a frame callback

Daniel Stone daniel at fooishbar.org
Mon May 25 13:08:11 PDT 2015


Hi,

On 25 May 2015 at 20:15, Rui Matos <tiagomatos at gmail.com> wrote:
> In some extreme cases with animated cursors at a high frame rate we
> could end up filling the wl_display outgoing buffer and end up with
> wl_display_flush() failing.
>
> In any case, using the frame callback to throttle ourselves is the
> right thing to do.

I agree, but it seems like this will lose updates posted when
set_cursor is awaiting a callback. I think the early-return case
should stash the pending values, and the frame callback should post &
clear the pending values.

Cheers,
Daniel


More information about the wayland-devel mailing list