[PATCH weston] desktop-shell: do not black out with startup "none"

[Pekka Paalanen]

On Tue, 26 May 2015 12:06:39 +0300
Pekka Paalanen <pekka.paalanen at collabora.co.uk> wrote:

> On Tue, 26 May 2015 11:54:52 +0300
> Pekka Paalanen <ppaalanen at gmail.com> wrote:
> 
> > From: Pekka Paalanen <pekka.paalanen at collabora.co.uk>
> > 
> > Do not use a black blanket surface when the startup animation is
> > specified to be "none". This is the final fix needed to make the
> > screenshot test deterministic and independent of weston-desktop-shell.
> > 
> > Previously, the black surface would cover all outputs until
> > weston-desktop-shell signalled ready. Then, depending on the set
> > animation, either the black surface was immediately removed (none) or a
> > fade-in started (fade).
> > 
> > Now, when there is no black surface at all for "none", the compositor
> > will show garbage until weston-desktop-shell gets everything up. This
> > may be undesireable but works for tests. To have the old "none"
> > behaviour back, I would propose to add a new startup-animation value
> > "black" for it.
> > 
> > Signed-off-by: Pekka Paalanen <pekka.paalanen at collabora.co.uk>
> > 
> > ---
> > 
> > Bryce, this patch should be good to land once someone gives it a
> > tested-by or a reviewed-by. When this lands, I think RC2 is ready for
> > release.
> 
> Well, just to be clear, RC2 would be ready from *my* behalf. I don't
> know about other bugs.

Meh, found one more.

'make distcheck' still fails even after all the fixes:

Could not open /home/pq/build/weston/weston-1.7.92/_build/../tests/reference/internal-screenshot-good-00.png: file not found
test "internal_screenshot":     signal 6, fail.

I guess this is because the new reference images are not distributed in
Makefile.am.

Hopefully this is the last problem this time.


Thanks,
pq