[PATCH v2] protocol: Improve data source notification around DnD progress

[Jonas Ådahl]

On Mon, Nov 02, 2015 at 05:46:35PM +0100, Carlos Garnacho wrote:
> Hey!,
> 
> On Sat, Oct 31, 2015 at 12:06 AM, Michael Catanzaro
> <mcatanzaro at igalia.com> wrote:
> > On Fri, 2015-10-30 at 21:55 +0100, Carlos Garnacho wrote:
> >> Changes since v1:
> >>   - Renamed events to have a common "dnd" namespace.
> >
> > I don't think this was a great change. The event occurs on drop, and
> > the previous name described that perfectly, whereas with the new name
> > it's not very clear how it's different from dnd_finished. Maybe
> > dnd_drop_performed would be better, if slightly redundant.
> 
> Yeah I see your point, the semantical difference between "performed"
> and "finished" may be blurry enough. Reading bits of the thread again,
> it might be what Jonas had in mind since the beginning? I'm stashing
> that locally, but will wait for more opinions before resending.

What I imagined was the change you did, but I guess 'dnd_drop_performed'
works as well, as what was performed was the drop of a drag and drop,
the drag and drop drop.


Jonas

> 
> >
> >> @@ -423,7 +423,9 @@
> >>       Indicate that the client can accept the given mime type, or
> >>       NULL for not accepted.
> >>
> >> -     Used for feedback during drag-and-drop.
> >> +     This request mandates the final result of the drag-and-drop
> >> +     operation. If the end result is that no mimetype is
> >> accepted,
> >> +     the drag source will receive drag_source.cancelled.
> >>        </description>
> >>
> >>        <arg name="serial" type="uint"/>
> >
> > Nit: "mandates" is not a great choice of word here... how about
> > "determines" instead?
> 
> Agreed (on both places), changed locally.
> 
> > Reviewed-by: Michael Catanzaro <mcatanzaro at igalia.com>
> 
> Thanks!
> 
>   Carlos
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/wayland-devel